What type of PR is this? (check all applicable)

• [ ] Refactor
• [ ] Feature
• [X] Bug Fix
• [ ] Optimization
• [ ] Documentation Update

Description

The main comment box on the articles detail page does not reset to default height after successful submission. The inline style height set on the textarea element is not being removed.

Related Tickets & Documents

Fixes #13298

Added tests?

• [ ] Yes
• [X] No, and this is why: this is a UI bug fix
• [ ] I need help with writing tests

[optional] What gif best describes this PR or how it makes you feel?

What type of PR is this? (check all applicable)

• [ ] Refactor
• [ ] Feature
• [x] Bug Fix
• [ ] Optimization
• [ ] Documentation Update

Description

Fix scroll-padding on article anchor links.

Related Tickets & Documents

Closes https://github.com/forem/forem/issues/9749

QA Instructions, Screenshots, Recordings

So there was a lingering issue with anchor links on dev.to: the Section #anchor links on articles would make the heading of said section hide behind the header. This PR aims to fix that.

To test this: Load up the minimal default article database, and head to http://localhost:3000/ricky_ms_franecki/the-mermaids-singing-ut-quasi-91k

Edit the URL to add #main-title at the end (for a position reset). Then, edit it to #modi to scroll to that section in the article.

Before:

After:

UI accessibility concerns?

If your PR includes UI changes, please replace this line with details on how accessibility is impacted and tested. For more info, check out the Forem Accessibility Docs.

Added tests?

• [ ] Yes
• [ ] No, and this is why: please replace this line with details on why tests have not been included
• [x] I need help with writing tests. (Can this be tested?)

What type of PR is this?

• [ ] Refactor
• [ ] Feature
• [x] Bug Fix
• [ ] Optimization
• [ ] Documentation Update

Description

Suggested tag during onboarding screen is made screen reader friendly with this PR. more context in https://github.com/forem/forem/pull/12384#discussion_r576524771

Related Tickets & Documents

closes https://github.com/forem/forem/issues/9585

QA Instructions, Screenshots, Recordings

1. Go to /onboarding
2. Go to screen "What are you interested in?"
3. Enable voice over and use keyboard to navigate the app

UI accessibility concerns?

This PR will make tags to follow during onboarding more accessible

Added tests?

• [ ] Yes
• [x] No, and this is why: It is a html change
• [ ] I need help with writing tests

[Forem core team only] How will this change be communicated?

Will this PR introduce a change that impacts Forem members or creators, the development process, or any of our internal teams? If so, please note how you will share this change with the people who need to know about it.

• [ ] I've updated the Developer Docs and/or Admin Guide, or Storybook (for Crayons components)
• [ ] I've updated the README or added inline documentation
• [X] I will share this change in a Changelog or in a forem.dev post
• [ ] I will share this change internally with the appropriate teams
• [ ] I'm not sure how best to communicate this change and need help
• [ ] This change does not need to be communicated, and this is why not: please replace this line with details on why this change doesn't need to be shared

What type of PR is this? (check all applicable)

• [x] Refactor
• [ ] Feature
• [x] Bug Fix
• [ ] Optimization
• [ ] Documentation Update

Description

Update Reddit liquid-tag styles issues and refactor some css

Related Tickets & Documents

QA Instructions, Screenshots, Recordings

before:

after:

UI accessibility concerns?

If your PR includes UI changes, please replace this line with details on how accessibility is impacted and tested. For more info, check out the Forem Accessibility Docs.

Added tests?

• [ ] Yes
• [X] No, and this is why: Not needed
• [ ] I need help with writing tests

[Forem core team only] How will this change be communicated?

Will this PR introduce a change that impacts Forem members or creators, the development process, or any of our internal teams? If so, please note how you will share this change with the people who need to know about it.

• [ ] I've updated the Developer Docs and/or Admin Guide, or Storybook (for Crayons components)
• [ ] I've updated the README or added inline documentation
• [ ] I will share this change in a Changelog or in a forem.dev post
• [ ] I will share this change internally with the appropriate teams
• [ ] I'm not sure how best to communicate this change and need help
• [ ] This change does not need to be communicated, and this is why not: please replace this line with details on why this change doesn't need to be shared

[optional] Are there any post deployment tasks we need to perform?

[optional] What gif best describes this PR or how it makes you feel?

What type of PR is this? (check all applicable)

• [x] Feature

Description

This moves us from hard-coding email configuration to place it as an environment variable. This provides flexibility to use other transactional email services.

Related Tickets & Documents

https://github.com/forem/rfcs/issues/152

QA Instructions, Screenshots, Recordings

No need to. This all depends on env vars

Added tests?

• [x] no, because they aren't needed

Added to documentation?

• [x] Yes, added to docs.dev.to

[optional] Are there any post-deployment tasks we need to perform?

• [ ] I need to update all Forem instances on Heroku first before this can be merged.

What type of PR is this? (check all applicable)

• [ ] Refactor
• [ ] Feature
• [x] Bug Fix
• [ ] Optimization
• [ ] Documentation Update

Description

Single-digit months and days are not compliant with the ECMAScript standard for date strings.

See: https://262.ecma-international.org/11.0/#sec-date-time-string-format

Fixes #13217

Related Tickets & Documents

QA Instructions, Screenshots, Recordings

1. Open Safari
2. Visit https://dev.to/dashboard/analytics
3. Click "Infinity"
4. You should see your metrics since April 1, 2019

UI accessibility concerns?

None, just a date format fix

Added tests?

• [ ] Yes
• [x] No, and this is why: If we were accepting arbitrary dates here, I think it would make sense to write a test, but this changes a hardcoded value to match the ECMAScript spec
• [ ] I need help with writing tests

[Forem core team only] How will this change be communicated?

• [ ] I've updated the Developer Docs and/or Admin Guide, or Storybook (for Crayons components)
• [ ] I've updated the README or added inline documentation
• [ ] I will share this change in a Changelog or in a forem.dev post
• [x] I will share this change internally with the appropriate teams
• [ ] I'm not sure how best to communicate this change and need help
• [ ] This change does not need to be communicated, and this is why not: please replace this line with details on why this change doesn't need to be shared

What type of PR is this? (check all applicable)

• [X] Feature

Description

This PR makes 2 changes to the GET /followers API endpoint:

1. The created_at value of the follow is now included in the API response.
2. A sort order can be specified (before it was hard-coded to created_at: :desc).

Note: I used sort as the parameter name because we use the same name here: https://github.com/forem/forem/pull/13137/files

Related Tickets & Documents

https://github.com/forem/internalEngineering/issues/404

QA Instructions, Screenshots, Recordings

1. Verify that the created_at timestamp is part of the API response.
2. Verify that sorting works.

UI accessibility concerns?

None, API only.

Added tests?

• [X] Yes

[Forem core team only] How will this change be communicated?

• [X] I will share this change internally with the appropriate teams

What type of PR is this? (check all applicable)

• [ ] Refactor
• [ ] Feature
• [ ] Bug Fix
• [ ] Optimization
• [ ] Documentation Update

Description

This adds "search by users.name" to the mention autocomplete component

Related Tickets & Documents

Closes https://github.com/forem/rfcs/issues/194

QA Instructions, Screenshots, Recordings

1. run bin/setup
2. load the website
3. test the mention autocomplete both in the post editor and in the comment editor
4. search using both names and username (I recommend changing the name of a local user so that it doesn't reflect its username completely)

UI accessibility concerns?

Nope

Added tests?

• [x] Yes
• [ ] No, and this is why: please replace this line with details on why tests have not been included
• [ ] I need help with writing tests

[Forem core team only] How will this change be communicated?

Will this PR introduce a change that impacts Forem members or creators, the development process, or any of our internal teams? If so, please note how you will share this change with the people who need to know about it.

• [ ] I've updated the Developer Docs and/or Admin Guide, or Storybook (for Crayons components)
• [ ] I've updated the README or added inline documentation
• [x] I will share this change in a Changelog or in a forem.dev post
• [x] I will share this change internally with the appropriate teams
• [ ] I'm not sure how best to communicate this change and need help
• [ ] This change does not need to be communicated, and this is why not: please replace this line with details on why this change doesn't need to be shared

What type of PR is this? (check all applicable)

• [ ] Refactor
• [ ] Feature
• [x] Bug Fix
• [ ] Optimization
• [ ] Documentation Update

Description

Adds an upper limit to Article.body_markdown

Related Tickets & Documents

Closes https://github.com/forem/internalEngineering/issues/410

QA Instructions, Screenshots, Recordings

1. load the console and load an article
2. article.body_markdown = 'a' * 801.kilobytes
3. article.validate!
4. get the error ActiveRecord::RecordInvalid: Validation failed: Body markdown is too long (maximum is 819200 characters)
5. article.body_markdown = 'a' * 800.kilobytes
6. article.validate! should yield true

Added tests?

• [x] Yes
• [ ] No, and this is why: please replace this line with details on why tests have not been included
• [ ] I need help with writing tests

[Forem core team only] How will this change be communicated?

Will this PR introduce a change that impacts Forem members or creators, the development process, or any of our internal teams? If so, please note how you will share this change with the people who need to know about it.

• [ ] I've updated the Developer Docs and/or Admin Guide, or Storybook (for Crayons components)
• [ ] I've updated the README or added inline documentation
• [ ] I will share this change in a Changelog or in a forem.dev post
• [x] I will share this change internally with the appropriate teams
• [ ] I'm not sure how best to communicate this change and need help
• [ ] This change does not need to be communicated, and this is why not: please replace this line with details on why this change doesn't need to be shared

</div>
<div class="gh-btn-container"><a class="gh-btn" href="https://github.com/forem/forem/pull/13418">View on GitHub</a></div>