Forem Creators and Builders

Lee
Lee

Posted on

Github Liquid Tag Issue

Hi there,

I have an issue on my Cloud hosted Forem where I can't embed a Github liquid tag.

I get the following error

base: GET https://api.github.com/repos/leewynne/terraformcloudtutorial: 401 - Bad credentials // See: https://docs.github.com/rest

I have auth with Github setup and working okay, is there something else I need to do either in Github or Forem for the liquid tags to display?

Thank you!
Lee

Discussion (9)

Collapse
ellativity profile image
Ella (she/her/elle)

@lee your Forem authentication with GitHub should be set up at the OAuth stage, so even if authentication was an issue with GitHub liquid tags (paging @ildi here because you might know more than I do about this), it should already be working fine due to OAuth.

Can you confirm that new sign ups are working fine with GitHub OAuth?

Collapse
ildi profile image
Ildi

I do not have Github OAuth setup for 1VIBE so I cannot test this at the moment.

@lee are you able to embed Github liquid tag in any of your self-hosted Forems?

Collapse
lee profile image
Lee Author

I have Github auth setup successfully on Meta Punk and I can't embed using liquid tag there atm.

Thread Thread
ellativity profile image
Ella (she/her/elle) • Edited on

So, interestingly @lee , I'm getting errors with GitHub liquid tags on Elastic Guru, too.

I've noticed in my GitHub Application Settings that both Elastic Guru and Meta Punk are categorized as GitHub apps rather than GitHub OAuth, and I wonder if you've got something different in the configuration here that's causing this differentiation?

Other Forems (both Forem-hosted and community self-hosted) that I use GitHub OAuth for, are listed under the OAuth tab, and liquid tags are working ok on those.

Could you have followed the config instructions for GitHub Apps instead of OAuth Apps?

Thread Thread
ellativity profile image
Ella (she/her/elle)

Hey @lee , just to add to this what @djuber pointed out to me, which is that liquid tag requests to GitHub from Forem

falls the most strongly under the "act as a user" category of that "differences" table

Which confirms to us that Forem needs to have GitHub apps configured for OAuth, and this will hopefully solve your issue. Dan also reminded me that users who signed in using GitHub before may have to reauthorize OAuth because it will technically be a different app. We don't know yet whether that will result in users being assigned new accounts, but if this becomes an issue then please loop us back in for additional assistance.

Thread Thread
lee profile image
Lee Author

Doh... I see it plain as day now... thanks @ellativity and @djuber 🤩

Thread Thread
lee profile image
Lee Author

All sorted now :D

Thread Thread
ellativity profile image
Ella (she/her/elle)

So happy to hear that! Glad we could help ☺️

Thread Thread
lee profile image
Lee Author

Heya, just checking back in on this one as I had to set it up again. Just confirming that if I need both Oauth and Liquid tags enabled then I need to go through the GitHub Apps creation (which also does oauth) rather than just the Oauth option. (the top option this list).

ouath

If that's the case then should documentation for github be updated to reflect whether the forem creator wants liquid tags or just auth?