Forem Creators and Builders 🌱

Discussion on: Resolved: This error is something new.

Collapse
 
djuber profile image
Daniel Uber • Edited

@akhil we saw that exact error on our side today, as well. It was introduced about 17 hours ago, and should be resolved as of 3 hours ago (if you pull a newer docker image to restart, or refresh the repo code, this error should go away).

The underlying issue was caused by a combination of factors on our end. The javascript code managed by the rails asset pipeline doesn't use the same language translation as the javascript code managed by webpacker, and a valid js syntax for optional chaining was added to a file where it wasn't understood. Additionally, the failure did show up once we merged the pull request in, but was not caught during automated testing because contributions from external contributors are not set to automatically build new images (which would have triggered the asset precompilation step and failed, bringing attention to the issue and blocking the merge).

github.com/forem/forem/pull/14018 and github.com/forem/forem/pull/15277 were the related changes.

It should be possible to add a precompilation step to avoid this in the future. The precompilation is a required step during the image build. I'm a little surprised you would see this if you're using the quay.io container images, they should not have built or been available for download in the broken state, but if you're building from the forem repo's code, this definitely was present for about 14 hours today.

Collapse
 
djuber profile image
Daniel Uber

Just a quick follow up - we added a required check for all PRs that should prevent this from happening again.

Collapse
 
akhil profile image
Akhil Naidu

I'm a little surprised you would see this if you're using the quay.io container images, they should not have built or been available for download in the broken state, but if you're building from the forem repo's code

Indeed I was building it from the Forem repo's code. And also thanks for the detailed error analysis.