forem.dev Community

loading...

Discussion on: More sidebar campaign generalisation please

Collapse
lee profile image
Lee Author

Submitted a PR for this

Generalize the sidebar campaign article published timeframe for smaller forems #11996

What type of PR is this? (check all applicable)

  • [ ] Refactor
  • [x] Feature
  • [ ] Bug Fix
  • [ ] Optimization
  • [ ] Documentation Update

Description

This PR adds a configurable timeframe for showing articles in the campaign sidebar, for smaller communities, the rate of submission will be much lower therefore this allows a Forem admin to adjust the timeframe so more stories show up in the count.

Related Tickets & Documents

This is related to issue #11968

QA Instructions, Screenshots, Recordings

Enabled and create a sidebar campaign in admin/config Set the required feature tag for articles to show in the count Enabled the campaign Set the desired campaign article expiry time

Set the published time for articles within the required tag to before and after the expiry time Note the change in the Stories count.

UI accessibility concerns?

None

Added tests?

  • [x] Yes
  • [ ] No, and this is why: please replace this line with details on why tests have not been included
  • [ ] I need help with writing tests

Added to documentation?

[optional] Are there any post deployment tasks we need to perform?

Nope!

[optional] What gif best describes this PR or how it makes you feel?

am i going to expire?