It was down to support of aria-pressed, however my notes were out of date and after a retest aria-pressed works fine (95%+ compatibility) for definitive states (true and false work for the value, mixed doesn't work well but that isn't relevant here).
The pattern in inclusive components works fine (which variation are you using?).
The biggest issue with the button is the same as addressed in my example, you have no information on current number of likes that is meaningful. Also when you change the state what is announced will be an interesting challenge.
My apologies for adding confusion, it is difficult to test things more than once every two years due to the number of screen readers and versions and at last check it was only 85% compatibility (checkbox is 100% as you can imagine) but some really old versions are no longer being supported / work properly so it is fine now!
Looks like I need to go and retest a few other things so I am not giving bad advice based on out dated information!
The pattern in inclusive components works fine (which variation are you using?)
The approach we're following is:
Button with type "button"
aria-pressed to communicate state
Static labeling (e.g. "Like" won't change to "Unlike")
The biggest issue with the button is the same as addressed in my example, you have no information on current number of likes that is meaningful
You're absolutely right and I think it's something we'll need to think about a bit. As you mentioned, an aria-live region when the network request succeeds is one option. At least if we update these to toggle buttons, the user now has some feedback on their action, which is an improvement over the current implementation.
As a bit of additional context we're also looking at this pattern for follow buttons in the app which currently suffer from the same problem. Keeping the approach consistent across on/off buttons like this will hopefully make things more maintainable (that's the hope anyway!).
My apologies for adding confusion
Not at all! Definitely keen for input in this area - like you say it's almost impossible to keep completely on top of everything and we're more likely to arrive at an approach that works well if we all communicate and share expertise 😊 Really appreciate you taking the time to feed in!
For further actions, you may consider blocking this person and/or reporting abuse
It was down to support of
aria-pressed, however my notes were out of date and after a retestaria-pressedworks fine (95%+ compatibility) for definitive states (true and false work for the value, mixed doesn't work well but that isn't relevant here).The pattern in inclusive components works fine (which variation are you using?).
The biggest issue with the button is the same as addressed in my example, you have no information on current number of likes that is meaningful. Also when you change the state what is announced will be an interesting challenge.
My apologies for adding confusion, it is difficult to test things more than once every two years due to the number of screen readers and versions and at last check it was only 85% compatibility (checkbox is 100% as you can imagine) but some really old versions are no longer being supported / work properly so it is fine now!
Looks like I need to go and retest a few other things so I am not giving bad advice based on out dated information!
The approach we're following is:
You're absolutely right and I think it's something we'll need to think about a bit. As you mentioned, an
aria-liveregion when the network request succeeds is one option. At least if we update these to toggle buttons, the user now has some feedback on their action, which is an improvement over the current implementation.As a bit of additional context we're also looking at this pattern for follow buttons in the app which currently suffer from the same problem. Keeping the approach consistent across on/off buttons like this will hopefully make things more maintainable (that's the hope anyway!).
Not at all! Definitely keen for input in this area - like you say it's almost impossible to keep completely on top of everything and we're more likely to arrive at an approach that works well if we all communicate and share expertise 😊 Really appreciate you taking the time to feed in!