Realistically we should at least 404 any tag with 0 published posts... Whether or not we technically delete it from the database.
I think this would be best. I’m certainly hoping that users do not behave badly, and I’m not seeing this problem occur yet but it’s good that we are discussing it.
I like this suggestion, too, as that's also the result you get from a tag that doesn't exist at all, so it does effectively delete/delist the tag.
I think in addition, it would be nice for tags with 0 posts to be undiscoverable except by admins using the tag manager, so even if there aren't a lot of posts on a Forem the 0 posts tags don't appear in Top Tags or similar lists.
Since tags get created whenever they are included in a post, the tag exists even with no published posts.
It has been determined that the expected behavior should be a 404 response. If the tag is supported than the expectation is that the admin wants it to show up, even with no posts. (Likely a no posts yet scenario.)
I also really liked that suggestion above to only show supported tags in the /tags page. Would be nice to be able to focus on the important tags but maybe also have a search feature to quickly navigate to any other tag you might be interested in.
For further actions, you may consider blocking this person and/or reporting abuse
I think this would be best. I’m certainly hoping that users do not behave badly, and I’m not seeing this problem occur yet but it’s good that we are discussing it.
Indeed! This is a great one to bring up, Ildi.
And I like Ben's point that tags with 0 published posts should 404. That makes a lotta sense.
I like this suggestion, too, as that's also the result you get from a tag that doesn't exist at all, so it does effectively delete/delist the tag.
I think in addition, it would be nice for tags with 0 posts to be undiscoverable except by admins using the tag manager, so even if there aren't a lot of posts on a Forem the 0 posts tags don't appear in Top Tags or similar lists.
Merged the 404 for 0 posts/unsupported tags. Will be live in Forem Cloud shortly.
What type of PR is this? (check all applicable)
Description
Since tags get created whenever they are included in a post, the tag exists even with no published posts.
It has been determined that the expected behavior should be a
404response. If the tag is supported than the expectation is that the admin wants it to show up, even with no posts. (Likely a no posts yet scenario.)Related Tickets & Documents
Closes github.com/forem/rfcs/issues/282
Originally came out of this discussion: forem.dev/ildi/is-it-possible-to-d...
Added/updated tests?
[Forem core team only] How will this change be communicated?
This should mostly just fill expected behavior.
Thanks for the update Ben!
I also really liked that suggestion above to only show supported tags in the
/tagspage. Would be nice to be able to focus on the important tags but maybe also have a search feature to quickly navigate to any other tag you might be interested in.