Forem Creators and Builders 🌱

Discussion on: Add cover image bug on Dev-ios / ForemWebView-iOS local build

Collapse
 
fdocr profile image
Fernando

Hey @lee , we had a contributor submit a PR over the weekend to migrate the DEV iOS app to SPM. I wanted to check back here to give you a heads up so you can give it another try now that the project is no longer using Carthage

Migrate to SPM for dependencies #244

  • Remove Carthage references and files
  • Add Swift Package Dependencies for push-notifications-swift, NotificationBanner and ForemWebView-ios
  • Amend ViewController.swift so project builds
    • Change import statement for NotificationBanner to NotificationBannerSwift
    • Add missing protocol requirements of ForemWebViewDelegate

What type of PR is this? (check all applicable)

  • [ ] Refactor
  • [x] Feature
  • [ ] Bug Fix
  • [ ] Documentation Update

Description

Migrate to Swift Package Manager from Carthage for dependencies

Related Tickets & Documents

Issue#241

Mobile & Desktop Screenshots/Recordings (if there are UI changes)

N/A

Added to documentation?

  • [ ] docs.dev.to
  • [x] readme
  • [ ] no documentation needed

What gif best describes this PR or how it makes you feel?

happy dancing! yay!

Collapse
 
lee profile image
Lee

Hi mate! This worked a treat 😎😎😎😎😎😎😎😎😎